Skip to content

abi: fix die refaddr and sort#8999

Merged
alpeng-jump merged 1 commit intomainfrom
alpeng/extract-abi
Apr 3, 2026
Merged

abi: fix die refaddr and sort#8999
alpeng-jump merged 1 commit intomainfrom
alpeng/extract-abi

Conversation

@alpeng-jump
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an optional CLI flag to make extract_abi.py output deterministic and easier to diff by sorting emitted type blocks by type name.

Changes:

  • Add --sorted CLI flag via argparse.
  • When enabled, capture generated output, split into blocks, sort by extracted type name, and print sorted blocks.

Comment thread contrib/tool/extract_abi.py Outdated
Comment thread contrib/tool/extract_abi.py Outdated
Comment thread contrib/tool/extract_abi.py Outdated
@github-actions
Copy link
Copy Markdown

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-406545575-perf per slot 0.121023 s 0.121029 s 0.005%
backtest mainnet-406545575-perf snapshot load 5.063 s 3.341 s -34.011%
backtest mainnet-406545575-perf total elapsed 121.023075 s 121.028701 s 0.005%
firedancer mem usage with mainnet.toml 1105.43 GiB 1105.43 GiB 0.000%

@alpeng-jump alpeng-jump changed the title abi: add sorted flag for extraction abi: fix die refaddr and sort Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-406545575-perf per slot 0.135101 s 0.136974 s 1.386%
backtest mainnet-406545575-perf snapshot load 3.562 s 3.329 s -6.541%
backtest mainnet-406545575-perf total elapsed 135.100739 s 136.974484 s 1.387%
firedancer mem usage with mainnet.toml 1106.43 GiB 1106.43 GiB 0.000%

Copy link
Copy Markdown
Collaborator

@ptaffet-jump ptaffet-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few small comments.

Comment thread contrib/tool/extract_abi.py Outdated
Comment thread contrib/tool/extract_abi.py Outdated
Comment thread contrib/tool/extract_abi.py Outdated
Copilot AI review requested due to automatic review settings April 2, 2026 09:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-406545575-perf per slot 0.113415 s 0.11332 s -0.084%
backtest mainnet-406545575-perf snapshot load 3.05 s 1.984 s -34.951%
backtest mainnet-406545575-perf total elapsed 113.415383 s 113.320221 s -0.084%
firedancer mem usage with mainnet.toml 1117.43 GiB 1117.43 GiB 0.000%

@alpeng-jump alpeng-jump merged commit 4d89dad into main Apr 3, 2026
21 checks passed
@alpeng-jump alpeng-jump deleted the alpeng/extract-abi branch April 3, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants