Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an optional CLI flag to make extract_abi.py output deterministic and easier to diff by sorting emitted type blocks by type name.
Changes:
- Add
--sortedCLI flag viaargparse. - When enabled, capture generated output, split into blocks, sort by extracted type name, and print sorted blocks.
Performance Measurements ⏳
|
0d5a8a1 to
8710818
Compare
Performance Measurements ⏳
|
ptaffet-jump
reviewed
Apr 1, 2026
Collaborator
ptaffet-jump
left a comment
There was a problem hiding this comment.
Looks good! A few small comments.
8710818 to
1c28864
Compare
Performance Measurements ⏳
|
ptaffet-jump
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.