restore: snapwm revert incr log update#8944
Merged
jvarela-jump merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Corrects an invariant check/log message in the SnapWM restore vinyl incremental revert path, aligning the runtime assertion with the intended control flow during incremental snapshot failure handling.
Changes:
- Fixes
FD_CRITcondition infd_snapwm_vinyl_revert_incrto assert the expectedtxn_activestate. - Updates the associated error message to accurately describe the failure case.
You can also share your feedback on Copilot code review. Take the survey.
0x0ece
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log / check correction.
Update: addressed point 14 in #9176.