FA-6143 add changelog rferenceid and txhash validation on completion#233
Open
FA-6143 add changelog rferenceid and txhash validation on completion#233
Conversation
Collaborator
|
The changelog might just confuse. We do not update it properly. I wouldn't start it now. |
yanivmo
requested changes
Mar 25, 2026
Collaborator
yanivmo
left a comment
yanivmo
left a comment
There was a problem hiding this comment.
You must also generate the unified version.
…d the unified version
yanivmo
requested changes
Mar 30, 2026
Collaborator
yanivmo
left a comment
yanivmo
left a comment
There was a problem hiding this comment.
- Roll back the changelog. Just leave it as it was.
- Use my exact wording, including capitalization. The AI generated descriptions use ambiguous terminology and put emphasis on wrong things. Use my proposed description, as is, adjusted to each location. I'd just do it manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.