Conversation
There was a problem hiding this comment.
Code Review
This pull request enhances the Firebase Auth integration tests by updating the GenerateEmailAddress utility to incorporate platform-specific labels and test names, which improves the traceability of generated test accounts. It also refactors several test cases for better robustness, including more explicit error checking for provider linking and additional debug logging. The review feedback suggests using std::to_string for more idiomatic and portable integer-to-string conversion and simplifying the email string construction logic.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request enhances the Firebase Auth integration tests by improving the GenerateEmailAddress utility to include platform-specific identifiers and sanitized test names, while also ensuring all generated emails are lowercase. Additionally, it introduces platform name macros, adds debug logging for failed user deletions, refactors the anonymous user linking test for better error verification, and removes a redundant test case. There are no review comments to provide feedback on.
Description
There are two noticeable issues in the nightly tests:
SignInWithBadEmail would regularly fail because the backend thought it was suspicious, which resulted in the wrong error. Just deleting that test, since that behavior doesn't really need to be tested anyway.
LinkAnonymousUserWithEmailCredential was not properly cleaning up the users it created, resulting in leftover users on the backend that needed to be cleaned up. Refactored the test to address it.
Also adjusted the generated emails, so that they can be more easily tracked back if they are not cleaned up properly.
Testing
https://github.com/firebase/firebase-cpp-sdk/actions/runs/25352154658
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.