Skip to content

update audio recorder to do non blocking read to avoid having blocking audio threads #8030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VinayGuthal wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update audio recorder to do non blocking read to avoid having blocking audio threads #8030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28d21ab
update android kt to not have blocking audio threads
VinayGuthal Apr 10, 2026
fc9b537
spotless apply
VinayGuthal Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions ai-logic/firebase-ai/src/main/kotlin/com/google/firebase/ai/common/util/android.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,22 @@ internal fun AudioRecord.readAsFlow() = flow {

while (true) {
if (recordingState != AudioRecord.RECORDSTATE_RECORDING) {
// delay uses a different scheduler in the backend, so it's "stickier" in its enforcement when
// compared to yield.
delay(0)
// Avoid busy looping when not recording
delay(20)
continue
}
val bytesRead = read(buffer, 0, buffer.size)

// Use non-blocking read to avoid leaking threads if the hardware blocks
val bytesRead = read(buffer, 0, buffer.size, AudioRecord.READ_NON_BLOCKING)

if (bytesRead > 0) {
emit(buffer.copyOf(bytesRead))
} else if (bytesRead == 0) {
// No data available yet, wait a bit
delay(10)
} else {
// Error read, small delay to avoid tight loop
delay(50)
}
// delay uses a different scheduler in the backend, so it's "stickier" in its enforcement when
// compared to yield.
delay(0)
}
}
Loading