Skip to content

dataconnect(change): internal refactor of connectorResourceName variable names#8025

Merged
dconeybe merged 4 commits intomainfrom
dconeybe/dataconnect/ConnectorResourceName
Apr 8, 2026
Merged

dataconnect(change): internal refactor of connectorResourceName variable names#8025
dconeybe merged 4 commits intomainfrom
dconeybe/dataconnect/ConnectorResourceName

Conversation

@dconeybe
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe commented Apr 8, 2026

Internal refactor in the Data Connect SDK to improve code clarity by renaming variables related to the connector resource name.

Highlights

  • Renamed requestName to connectorResourceName in DataConnectGrpcClient to more accurately reflect its contents.
  • Updated unit tests to use the new variable naming convention.
  • Added an entry to CHANGELOG.md documenting the change.

Changelog

Details
  • CHANGELOG.md: Added an entry for the internal refactor and assigned the pull request number.
  • DataConnectGrpcClient.kt: Renamed the private requestName property and its usages to connectorResourceName.
  • DataConnectGrpcClientUnitTest.kt: Updated unit tests to reflect the variable name change from expectedName to expectedConnectorResourceName.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dconeybe
Copy link
Copy Markdown
Contributor Author

dconeybe commented Apr 8, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs an internal refactor to improve code clarity by renaming variables to be more descriptive. Specifically, 'requestName' was renamed to 'connectorResourceName' in 'DataConnectGrpcClient.kt', with corresponding updates made to the unit tests. I have no feedback to provide as there are no review comments.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@dconeybe dconeybe marked this pull request as ready for review April 8, 2026 19:40
@dconeybe dconeybe merged commit 1a32c9c into main Apr 8, 2026
43 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/ConnectorResourceName branch April 8, 2026 22:41
@github-actions github-actions bot mentioned this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants