feat(appcheck): Add support for minting limited-use tokens and custom JTI#3027
feat(appcheck): Add support for minting limited-use tokens and custom JTI#3027lahirumaramba wants to merge 8 commits intomainfrom
Conversation
Summary of ChangesHello @lahirumaramba, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the App Check module by enabling the creation of limited use tokens. This feature provides developers with the ability to generate tokens that offer replay protection, making them ideal for securing one-time operations or session-specific interactions within applications. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for creating limited-use App Check tokens by adding a limitedUse parameter to the createToken() API. The changes are well-implemented across the API, client, and internal methods, and are accompanied by thorough unit and integration tests. My review includes one suggestion to enhance input validation for the new limitedUse parameter to improve robustness and provide clearer feedback to developers on invalid usage.
0cebdc5 to
016b022
Compare
0e89132 to
0a1d94a
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for minting limited-use App Check tokens by adding jti and limitedUse options to the createToken() API. The changes include updates to the API definition, implementation of validation logic for the new options, and corresponding unit and integration tests. The new validation ensures that jti is only specified when limitedUse is set to true, which is a good practice for maintaining API consistency and preventing misuse. Overall, the changes are well-implemented and tested.
test/integration/app-check.spec.ts
Outdated
| }); | ||
| }); | ||
|
|
||
| it('should succeed with a vaild limited use token', function () { |
This PR adds support for the
limitedUseandjtiparameters in thecreateToken()API of the App Check module. This allows users to generate tokens with replay protection, suitable for one-time use or session-based contexts.RELEASE_NOTE: Added support for creating limited use App Check tokens with custom
jtiin thecreateToken()API.Internal: go/firebase-admin-node-limited-use-fac-tokens