Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sparse-file-opsdeltas directly to a staged filesystem tree restored from the pristine base package instead of round-tripping through an intermediate rebuilt archive during update materializationWhy
A recent Linux x64 update spent most of its time preparing a tiny sparse delta against a cached full package.
The hot path was not network transfer or app shutdown. It was local archive work:
That makes sparse deltas pay full-archive costs even when the delta payload itself is very small.
Root Cause
UpdateManagertreated sparse file deltas like archive deltas all the way through staging. The updater rebuilt a full archive in memory and then extracted it, even though the sparse delta format already describes filesystem operations.What Changed
UpdateManagerthat:Impact
For sparse deltas, this removes an unnecessary archive round-trip from the apply path while preserving the packaged archive basis required for persistent assets and hash-stable directory metadata.
Validation
./scripts/sync-surge-core-vendor.sh --check./scripts/check-version-sync.shcargo fmt --all -- --checkRUSTFLAGS='-D warnings' cargo test --workspacecargo clippy --all-targets --all-features -- -D warningscargo clippy --workspace --lib --bins --examples -- -D warnings -D clippy::unwrap_used -D clippy::expect_usedcargo clippy --workspace --all-targets --all-features -- -D warnings -W clippy::pedanticdotnet format dotnet/Surge.slnx --verify-no-changesdotnet test dotnet/Surge.slnx --configuration Release