fix(cli): honor restore installer channel selection#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
restore --channelsupport and thread the selected channel through the restore pathinstaller.ymlmetadata from the selected channel instead of the app default channelrestore -i --channelflowRoot Cause
Installer-only restore and remote published-installer lookup were coupled to
app.channels.first()or the manifest default channel. That meant rebuilding installers after promoting an existing release required manifest rewriting or other downstream workarounds.Impact
surge restore -i --channel productionnow resolves releases onproductioninstaller.ymlpersists the requested runtime channel metadataValidation
cargo check -p surge-cli./scripts/check-maintainability.shcargo test -p surge-cli cli::tests::restore_cargo test -p surge-cli execute_installers_only_cargo test -p surge-cli plan_remote_published_installercargo clippy -p surge-cli --all-targets --all-features -- -D warnings -W clippy::pedantic./scripts/sync-surge-core-vendor.sh --check./scripts/check-version-sync.shcargo fmt --all -- --checkRUSTFLAGS="-D warnings" cargo test --workspacecargo clippy --all-targets --all-features -- -D warningscargo clippy --workspace --lib --bins --examples -- -D warnings -D clippy::unwrap_used -D clippy::expect_usedcargo clippy --workspace --all-targets --all-features -- -D warnings -W clippy::pedanticdotnet format dotnet/Surge.slnx --verify-no-changesdotnet test dotnet/Surge.slnx --configuration ReleaseMigration Notes