Skip to content

ci: promote maintainability guardrail to blocking#77

Merged
peters merged 1 commit intomainfrom
refactor/maintainability-phase-2
Apr 10, 2026
Merged

ci: promote maintainability guardrail to blocking#77
peters merged 1 commit intomainfrom
refactor/maintainability-phase-2

Conversation

@peters
Copy link
Copy Markdown
Contributor

@peters peters commented Apr 10, 2026

Summary

  • make the maintainability CI job blocking instead of advisory
  • refresh the maintainability docs to describe the now-empty baseline ledger
  • mark the first maintainability cleanup wave as complete in the rollout plan

Behavior Impact

  • new oversized Rust source files in crates/*/src now fail CI immediately unless a reviewed baseline entry is added
  • no user-facing runtime behavior changes

Test Evidence

  • ./scripts/check-maintainability.sh
  • ./scripts/sync-surge-core-vendor.sh --check
  • ./scripts/check-version-sync.sh
  • cargo fmt --all -- --check
  • RUSTFLAGS="-D warnings" cargo test --workspace
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo clippy --workspace --lib --bins --examples -- -D warnings -D clippy::unwrap_used -D clippy::expect_used
  • cargo clippy --workspace --all-targets --all-features -- -D warnings -W clippy::pedantic
  • dotnet format dotnet/Surge.slnx --verify-no-changes
  • dotnet test dotnet/Surge.slnx --configuration Release

Migration Notes

  • none

@peters peters marked this pull request as ready for review April 10, 2026 13:39
@peters peters merged commit 8dee8a5 into main Apr 10, 2026
12 checks passed
@peters peters deleted the refactor/maintainability-phase-2 branch April 10, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant