refactor: migrate to ucantone typed Binding[Args, OK]#31
Merged
Conversation
Adopt the ucantone changes from #17 (Binding[Args, OK]), #18 (big ints), and - Drop commands/bind.go: the MustParse wrapper was a pass-through to binding.Bind(command.MustParse(...)), so command declarations now call ucantone directly as binding.Bind[*Args, *OK](command.MustParse("/x")). - Pair every command with its existing OK result type as the second type parameter (#17). - Regenerate commands/access cbor/json: the Command field now marshals via command.Command's own methods rather than as a string (#21). - Update retrieval tests from validator/bindcom to binding.Bind.
frrist
force-pushed
the
frrist/ucantone-binding-migration
branch
from
66f4009 to
1634476
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt the ucantone changes from #17 (Binding[Args, OK]), #18 (big ints), and