Fix stat/file tests on filehandles and stat _ parsing#245
Merged
Conversation
Store filePath in RuntimeIO when opening files so stat($fh) and file test operators (-f $fh, etc.) can access the underlying file metadata instead of returning EBADF. Fix stat _ / lstat _ parsing where _ was matched by the ALLCAPS bareword regex and treated as a filehandle glob instead of the special last-stat-buffer identifier. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filePathinRuntimeIOwhen opening files sostat($fh)and file test operators (-f $fh, etc.) can access the underlying file's metadata instead of returning EBADFstat _/lstat _parsing where_was matched by the ALLCAPS bareword regex and treated as a filehandle glob instead of the special last-stat-buffer identifierFileTestOperatorto extract sharedevaluateFileTest()method used by both string and filehandle code pathsStat.javato extract sharedstatPath()method for both string and filehandle statTest plan
./gradlew testpassesGenerated with Devin