feat: cherry-pick checklist categories and --integration doc rename#7
Merged
feat: cherry-pick checklist categories and --integration doc rename#7
Conversation
Two of the five candidates from fellowship-dev/pylot#289: - Item 2: checklist philosophy — added the six quality dimensions (Completeness, Clarity, Consistency, Measurability, Coverage, Edge Cases) as explicit categories in checklist.md. Skipped the ~300 lines of upstream examples per the issue's terse-templates rule. - Item 5: replaced deprecated --ai with --integration in user-facing docs (README.md, CONTRIBUTING.md). CLI source kept as-is for backward compatibility (matches upstream PR github#2359). Item 3 (feature auto-directory naming) is already implemented: specify.md reads .specify/init-options.json for branch_numbering (sequential|timestamp), and the CLI's --branch-numbering flag writes it during specify init. No template change needed. Items 1 (extension hooks) and 4 (feature metadata persistence) deferred — medium-effort changes that need closer evaluation against the terse-templates philosophy. Refs fellowship-dev/pylot#289 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two of the five upstream cherry-picks from fellowship-dev/pylot#289. Each adapted to fellowship-dev's terse-templates philosophy — not copy-pasted from upstream.
templates/commands/checklist.md. The "unit tests for English" framing was already in the file from a prior sync; this just makes the category list complete (Measurability was missing) and tightens the spec-section reference convention. Skipped the ~300 lines of upstream examples, per the issue's terse-templates rule.--integrationflag: replaced deprecated--ai/--ai-skillswith--integration/--integration-options="--skills"in user-facing docs (README.md,CONTRIBUTING.md). Mirrors upstream PR docs: replace deprecated --ai flag with --integration in all documentation github/spec-kit#2359, which is also docs-only — the CLI keeps--aias a deprecated alias for backward compatibility.Already done — no change needed
templates/commands/specify.mdalready reads.specify/init-options.jsonforbranch_numberingand supports bothsequential(NNN) andtimestamp(YYYYMMDD-HHMMSS). The CLI's--branch-numberingflag persists the choice duringspecify init. Likely landed during the v0.8.1 sync (sync: upstream spec-kit v0.8.1 #2/terse: rewrite v0.8.1 command templates — 1998 → 642 lines #3). Verified by reading both the template logic andsrc/specify_cli/__init__.py. No template / CLI change needed for this PR.Deferred
.specify/feature.json): requiresscripts/bash/common.shchanges and a workflow design call.Note on the issue body
Issue 289 says Item 5 lives in
scripts/bash/check-prerequisites.sh. That script does not contain--ai. Upstream PR github#2359 is documentation-only — README, installation docs, CONTRIBUTING. Updated those instead.Test plan
bash -n scripts/bash/check-prerequisites.shclean (script unchanged).grep -n '\-\-ai\b' README.md CONTRIBUTING.mdreturns no hits.Refs fellowship-dev/pylot#289 — does not close (items 1, 4 still pending; item 3 already implemented).