Skip to content

fix: restore __SPECKIT_COMMAND_PLAN__ marker and specify hook note#5

Merged
maxfindel merged 1 commit intomainfrom
fix/restore-speckit-command-plan-marker
Apr 24, 2026
Merged

fix: restore __SPECKIT_COMMAND_PLAN__ marker and specify hook note#5
maxfindel merged 1 commit intomainfrom
fix/restore-speckit-command-plan-marker

Conversation

@maxfindel
Copy link
Copy Markdown

What

Minimal fix for 6 CI failures introduced by the merged terse rewrite (PR fellowship-dev/spec-kit#4).

Failures fixed

Test Root cause
TestSharedInfraCommandRefs ×5 __SPECKIT_COMMAND_PLAN__ marker dropped from plan-template.md
TestSharedInfraCommandRefs (tasks) __SPECKIT_COMMAND_TASKS__ marker dropped from tasks-template.md
TestClaudeHookCommandNote::test_hook_note_injected_in_skills_with_hooks "replace dots" hook note dropped from templates/commands/specify.md

Changes

  • templates/plan-template.md: Added __SPECKIT_COMMAND_PLAN__ to the project-structure comment so _install_shared_infra can resolve it to /speckit.plan or /speckit-plan per integration type
  • templates/tasks-template.md: Added __SPECKIT_COMMAND_TASKS__ to the generator comment for the same reason
  • templates/commands/specify.md: Expanded Pre-Execution to a proper bullet list so _inject_hook_command_note finds its - For each executable hook, output the following trigger

Verification

All 6 previously failing tests now pass. Full test suite green: 1698 passed, 29 skipped.

🤖 Generated with Claude Code

PR #4 terse rewrite dropped two substitution markers causing 6 CI failures:
- plan-template.md: missing __SPECKIT_COMMAND_PLAN__ (TestSharedInfraCommandRefs ×5)
- tasks-template.md: missing __SPECKIT_COMMAND_TASKS__ (TestSharedInfraCommandRefs ×1)
- specify.md: missing replace-dots hook note (TestClaudeHookCommandNote ×1)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@maxfindel maxfindel merged commit 1a84f1f into main Apr 24, 2026
11 checks passed
@maxfindel maxfindel deleted the fix/restore-speckit-command-plan-marker branch April 24, 2026 20:03
@maxfindel
Copy link
Copy Markdown
Author

CTO Review — #5

Status: Post-merge review (PR already merged to main) | CI: ✅ All 11 checks green


Summary

Minimal surgical fix for 6 test failures introduced by the terse rewrite in PR fellowship-dev/spec-kit#4. Three files changed (+5/-3): the __SPECKIT_COMMAND_PLAN__ and __SPECKIT_COMMAND_TASKS__ markers were restored to their respective templates, and the specify.md Pre-Execution section was restructured into a proper bullet list so the _inject_hook_command_note scanner reliably finds its trigger phrase.


Strengths

  • Laser-focused scope — 5 additions, 3 deletions, zero scope creep. Every line has a corresponding test failure it fixes.
  • Full CI green — pytest on ubuntu+windows across Python 3.11/3.12/3.13, ruff, markdownlint, CodeQL, and CodeQL Analyze all pass. 1698 tests passed, 29 skipped.
  • Clear PR narrative — the failure table (test name → root cause) makes causality immediately obvious without having to read code.
  • No Closes #N — no premature issue closure risk.

Issues

None. The changes are correct, minimal, and well-verified.


Template Impact

Template Change Effect
templates/plan-template.md Added __SPECKIT_COMMAND_PLAN__ to project-structure comment _install_shared_infra can now resolve the placeholder to /speckit.plan or /speckit-plan per integration type
templates/tasks-template.md Added __SPECKIT_COMMAND_TASKS__ to generator comment Same resolution pattern for task-list command injection
templates/commands/specify.md Expanded Pre-Execution to bullet list format _inject_hook_command_note trigger phrase now reliably found; hook notes will be injected correctly in all downstream speckit consumers

Downstream teams using speckit-runner will see correct command resolution and hook note injection restored. No behavior change for teams that don't use hooks.


Verdict: ✅ Clean fix. Correct, minimal, and verified. No action items.

@maxfindel maxfindel added the reviewed First-pass review completed label Apr 24, 2026
@maxfindel
Copy link
Copy Markdown
Author

Double-Check Review: PR #5 — fix: restore SPECKIT_COMMAND_PLAN marker and specify hook note

Reviewer: tooling.cto double-check
Branch: fix/restore-speckit-command-plan-markermain (already merged 2026-04-24)


Intent

Surgical fix for 6 CI test failures introduced by the terse rewrite in PR fellowship-dev/spec-kit#4. Three files changed (+5/-3), each targeting a specific test failure.

Implementation

  • templates/plan-template.md: Added __SPECKIT_COMMAND_PLAN__ marker in the project-structure comment so _install_shared_infra can resolve it to /speckit.plan or /speckit-plan
  • templates/tasks-template.md: Added __SPECKIT_COMMAND_TASKS__ to the generator comment for identical resolution
  • templates/commands/specify.md: Expanded Pre-Execution from a single line to a bullet list containing the For each executable hook, output the following trigger phrase that _inject_hook_command_note scans for

Curated CI Findings

No CI review comments found — reviewed diff directly. All 11 CI checks green (pytest on ubuntu+windows across Python 3.11/3.12/3.13, ruff, markdownlint, CodeQL, Analyze).

New Issues (not caught by CI)

None. All three marker placements were verified locally:

  • __SPECKIT_COMMAND_PLAN__ present at plan-template.md:30
  • __SPECKIT_COMMAND_TASKS__ present at tasks-template.md:30
  • For each executable hook trigger present at specify.md:24

Closes vs Refs Check

No Closes #N / Fixes #N / Resolves #N in PR body — no premature issue closure risk. ✅

Tests After Fixes

  • Suite: CI green — pytest passed 1698/1698 (29 skipped) across all matrix combinations per PR author report and CI runs
  • Local run: Not possible — environment Python 3.10 < spec-kit's required >=3.11 (pre-existing constraint, not a PR issue)
  • Regressions: None

Verdict

✅ Ready — changes are correct, minimal, and verified. PR already merged cleanly.

@maxfindel maxfindel added the double-checked Double-checked by agent label Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

double-checked Double-checked by agent reviewed First-pass review completed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant