Conversation
PR #4 terse rewrite dropped two substitution markers causing 6 CI failures: - plan-template.md: missing __SPECKIT_COMMAND_PLAN__ (TestSharedInfraCommandRefs ×5) - tasks-template.md: missing __SPECKIT_COMMAND_TASKS__ (TestSharedInfraCommandRefs ×1) - specify.md: missing replace-dots hook note (TestClaudeHookCommandNote ×1) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CTO Review — #5Status: Post-merge review (PR already merged to main) | CI: ✅ All 11 checks green SummaryMinimal surgical fix for 6 test failures introduced by the terse rewrite in PR fellowship-dev/spec-kit#4. Three files changed (+5/-3): the Strengths
IssuesNone. The changes are correct, minimal, and well-verified. Template Impact
Downstream teams using speckit-runner will see correct command resolution and hook note injection restored. No behavior change for teams that don't use hooks. Verdict: ✅ Clean fix. Correct, minimal, and verified. No action items. |
Double-Check Review: PR #5 — fix: restore SPECKIT_COMMAND_PLAN marker and specify hook noteReviewer: tooling.cto double-check IntentSurgical fix for 6 CI test failures introduced by the terse rewrite in PR fellowship-dev/spec-kit#4. Three files changed (+5/-3), each targeting a specific test failure. Implementation
Curated CI FindingsNo CI review comments found — reviewed diff directly. All 11 CI checks green (pytest on ubuntu+windows across Python 3.11/3.12/3.13, ruff, markdownlint, CodeQL, Analyze). New Issues (not caught by CI)None. All three marker placements were verified locally:
Closes vs Refs CheckNo Tests After Fixes
Verdict✅ Ready — changes are correct, minimal, and verified. PR already merged cleanly. |
What
Minimal fix for 6 CI failures introduced by the merged terse rewrite (PR fellowship-dev/spec-kit#4).
Failures fixed
TestSharedInfraCommandRefs×5__SPECKIT_COMMAND_PLAN__marker dropped fromplan-template.mdTestSharedInfraCommandRefs(tasks)__SPECKIT_COMMAND_TASKS__marker dropped fromtasks-template.mdTestClaudeHookCommandNote::test_hook_note_injected_in_skills_with_hookstemplates/commands/specify.mdChanges
templates/plan-template.md: Added__SPECKIT_COMMAND_PLAN__to the project-structure comment so_install_shared_infracan resolve it to/speckit.planor/speckit-planper integration typetemplates/tasks-template.md: Added__SPECKIT_COMMAND_TASKS__to the generator comment for the same reasontemplates/commands/specify.md: Expanded Pre-Execution to a proper bullet list so_inject_hook_command_notefinds its- For each executable hook, output the followingtriggerVerification
All 6 previously failing tests now pass. Full test suite green: 1698 passed, 29 skipped.
🤖 Generated with Claude Code