Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request resolves issue #13 by introducing a new Jupyter Notebook for running parametric diffusion simulations and updating the CI workflow to execute and test notebooks within a Docker container.
- Added diffusion.ipynb to demonstrate ParametricDiffusion problem simulations across multiple mu values.
- Added a CI workflow in .github/workflows/ci.yml to build a Docker image, execute notebooks, perform linting, and run tests.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| diffusion.ipynb | New notebook for the parametric diffusion simulation. |
| .github/workflows/ci.yml | New CI configuration to build a Docker environment and run tests. |
| build-and-test-docker: | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: ${{ github.job }} |
There was a problem hiding this comment.
The container image is set using '${{ github.job }}', which may not resolve to a valid Docker image. Consider specifying the correct image name (e.g. 'ci-environment' built in a previous step) to ensure the container is properly configured.
Suggested change
| image: ${{ github.job }} | |
| image: ci-environment |
added 10 commits
April 22, 2025 10:55
…ass in Diffusion_param.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.