Skip to content

feat: rewrite#199

Draft
climba03003 wants to merge 2 commits intomainfrom
refactor
Draft

feat: rewrite#199
climba03003 wants to merge 2 commits intomainfrom
refactor

Conversation

@climba03003
Copy link
Copy Markdown
Member

@climba03003 climba03003 commented Jan 9, 2023

Resolves #118

TODO

  • group the code that provide same feature as function
  • split into multiple files for better management
  • variables name to be consistence over the package and use full name
  • add comments to explain the details
  • remove .express
  • remove .after
  • split .ready and .start

Checklist

@climba03003 climba03003 changed the title refactor: split in multiple files feat: rewrite Jan 9, 2023
@mcollina
Copy link
Copy Markdown
Member

Thanks for taking this on!

@climba03003
Copy link
Copy Markdown
Member Author

climba03003 commented Jan 21, 2025

Using Promise.try to simplify the codebase.
Removed .after and replace with .then.

Since we are using the Promise.try, some behavior is changed.

TODO List

  • Add the toJSON and prettyPrint back.
  • Add the test back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite avvio from scratch

3 participants