fix warning C4702: unreachable code#368
Merged
lemire merged 1 commit intofastfloat:mainfrom Feb 23, 2026
Merged
Conversation
Member
|
Running tests. |
|
See #367. Only occurs with warning level It can be simply circumvented by consumers via #ifdef _MSC_VER
#pragma warning(push)
#pragma warning(disable: 4702) // unreachable code
#endif
#include "fast_float.h"
#ifdef _MSC_VER
#pragma warning(pop)
#endifAt least, that's what was working for me. |
Member
|
I am happy to merge this. |
Member
|
Will be part of the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it fixes
E:\jenkins\workspace\gerrit_windows_wsl\workdir\UnpackedTarball\fast_float\include\fast_float\float_common.h(317) : error C2220: the following warning is treated as an error
E:\jenkins\workspace\gerrit_windows_wsl\workdir\UnpackedTarball\fast_float\include\fast_float\float_common.h(373) : error C2220: the following warning is treated as an error
E:\jenkins\workspace\gerrit_windows_wsl\workdir\UnpackedTarball\fast_float\include\fast_float\float_common.h(317) : warning C4702: unreachable code
E:\jenkins\workspace\gerrit_windows_wsl\workdir\UnpackedTarball\fast_float\include\fast_float\float_common.h(373) : warning C4702: unreachable code