Skip to content

fix: update tests to work with breaking changes in recent synapse versions#73

Merged
FrenchGithubUser merged 1 commit intomainfrom
thomast/fix-tests-new-synapse
Jan 7, 2026
Merged

fix: update tests to work with breaking changes in recent synapse versions#73
FrenchGithubUser merged 1 commit intomainfrom
thomast/fix-tests-new-synapse

Conversation

@FrenchGithubUser
Copy link
Copy Markdown
Member

@FrenchGithubUser FrenchGithubUser commented Jan 7, 2026

fix: update tests to work with breaking changes in recent synapse
versions

  • Clock moved from synapse.util to synapse.util.clock
  • Clock.__init__ now requires a server_name argument to support
    easier metric setups and multi-tenancy
  • LoggingDatabaseConnection.__inti__ now uses keyword-only arguments,
    and requires server_name
  • HomeServer.__init__ no long accepts version_string argument

@FrenchGithubUser FrenchGithubUser requested a review from a team as a code owner January 7, 2026 09:54
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.08%. Comparing base (3766167) to head (29de5c4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   83.08%   83.08%           
=======================================
  Files          18       18           
  Lines        1874     1874           
  Branches      193      193           
=======================================
  Hits         1557     1557           
  Misses        234      234           
  Partials       83       83           
Files with missing lines Coverage Δ
tests/__init__.py 89.56% <100.00%> (ø)
tests/server.py 78.65% <100.00%> (ø)
tests/unittest.py 86.41% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af0d34...29de5c4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nico-famedly

This comment was marked as outdated.

@FrenchGithubUser FrenchGithubUser force-pushed the thomast/fix-tests-new-synapse branch 2 times, most recently from 31feaa4 to 591c0cd Compare January 7, 2026 10:21
@FrenchGithubUser FrenchGithubUser changed the title fix: update tests to work with latest synapse version fix: update tests to work with breaking changes in recent synapse versions Jan 7, 2026
versions

- `Clock` moved from `synapse.util` to `synapse.util.clock`
- `Clock.__init__` now requires a `server_name` argument to support
  easier metric setups and multi-tenancy
- `LoggingDatabaseConnection.__inti__` now uses keyword-only arguments,
  and requires `server_name`
- `HomeServer.__init__` no long accepts `version_string` argument
@FrenchGithubUser FrenchGithubUser force-pushed the thomast/fix-tests-new-synapse branch from 591c0cd to 29de5c4 Compare January 7, 2026 10:40
@FrenchGithubUser FrenchGithubUser requested a review from a team as a code owner January 7, 2026 10:40
@FrenchGithubUser FrenchGithubUser merged commit 29de5c4 into main Jan 7, 2026
3 checks passed
@FrenchGithubUser FrenchGithubUser deleted the thomast/fix-tests-new-synapse branch January 7, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants