fix: update tests to work with breaking changes in recent synapse versions#73
Merged
FrenchGithubUser merged 1 commit intomainfrom Jan 7, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 83.08% 83.08%
=======================================
Files 18 18
Lines 1874 1874
Branches 193 193
=======================================
Hits 1557 1557
Misses 234 234
Partials 83 83
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
nico-famedly
approved these changes
Jan 7, 2026
This comment was marked as outdated.
This comment was marked as outdated.
31feaa4 to
591c0cd
Compare
emgrav
approved these changes
Jan 7, 2026
versions - `Clock` moved from `synapse.util` to `synapse.util.clock` - `Clock.__init__` now requires a `server_name` argument to support easier metric setups and multi-tenancy - `LoggingDatabaseConnection.__inti__` now uses keyword-only arguments, and requires `server_name` - `HomeServer.__init__` no long accepts `version_string` argument
591c0cd to
29de5c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: update tests to work with breaking changes in recent synapse
versions
Clockmoved fromsynapse.utiltosynapse.util.clockClock.__init__now requires aserver_nameargument to supporteasier metric setups and multi-tenancy
LoggingDatabaseConnection.__inti__now uses keyword-only arguments,and requires
server_nameHomeServer.__init__no long acceptsversion_stringargument