fix(ebpf): zero-init container and pmc events for defense-in-depth#635
Open
yairfalse wants to merge 1 commit into
Open
fix(ebpf): zero-init container and pmc events for defense-in-depth#635yairfalse wants to merge 1 commit into
yairfalse wants to merge 1 commit into
Conversation
yairfalse
commented
May 3, 2026
Collaborator
Author
yairfalse
left a comment
There was a problem hiding this comment.
LGTM (review-only — self-authored, can't formally approve).
Three single-line __builtin_memset insertions at exactly the right places — immediately after each successful bpf_ringbuf_reserve in handle_oom, handle_exit, and sample_pmc. Matches the canonical pattern from storage_monitor.c:174 and network_monitor.c:214.
Today these structs are __attribute__((packed)) so there's no padding to leak, but this closes the door on a class of info-leak bugs that would otherwise appear silently the first time someone adds a non-aligned field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
These event structs are currently packed, but zeroing reserved ring-buffer events matches the other observers and prevents future padding additions from leaking kernel stack bytes.
Test plan