fix(ebpf): check bpf_core_read return for task->exit_code#633
Open
yairfalse wants to merge 1 commit into
Open
Conversation
yairfalse
commented
May 3, 2026
Collaborator
Author
yairfalse
left a comment
There was a problem hiding this comment.
LGTM (review-only — self-authored, can't formally approve).
Minimum-viable correctness fix — exactly the two-line change the bug needed. Failed bpf_core_read is now distinguishable from a clean exit (which the BPF-side filter at line 140 was previously masking).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A failed task->exit_code read left exit_code at zero, making the BPF-side clean-exit filter silently drop the event as if the process exited normally.
Test plan