Skip to content

feat: RCU route table — zero locks on select_backend (40ns → 33ns) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yairfalse wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: RCU route table — zero locks on select_backend (40ns → 33ns) #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5287ec
feat: RCU route table — zero locks on select_backend hot path
yairfalse Mar 27, 2026
54c86ad
fix: address PR #64 review feedback
yairfalse Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 4 additions & 22 deletions control/src/admin/local_query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ impl GatewayQuery for LocalGatewayQuery {
open_circuits,
exhausted_rate_limiters,
listeners: vec![],
cache_stats: Some(self.cache_stats_internal()),
cache_stats: None, // LRU cache removed — ArcSwap is faster
})
}

Expand Down Expand Up @@ -117,7 +117,9 @@ impl GatewayQuery for LocalGatewayQuery {
}

async fn cache_stats(&self) -> anyhow::Result<Option<CacheStats>> {
Ok(Some(self.cache_stats_internal()))
// LRU cache was removed — ArcSwap route snapshot is faster.
// Return None to signal caching is not applicable.
Ok(None)
}

async fn metrics_snapshot(
Expand Down Expand Up @@ -163,23 +165,3 @@ impl GatewayQuery for LocalGatewayQuery {
anyhow::bail!("undrain_backend not yet implemented via admin API")
}
}

impl LocalGatewayQuery {
fn cache_stats_internal(&self) -> CacheStats {
let (hits, misses) = self.router.get_cache_stats();
let size = self.router.get_cache_size();
let total = hits + misses;
let hit_rate = if total > 0 {
hits as f64 / total as f64
} else {
0.0
};

CacheStats {
hits,
misses,
size,
hit_rate,
}
}
}
Loading
Loading