Skip to content

fix(circuit_breaker): clear rate keys on auto-reset #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
levleontiev wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(circuit_breaker): clear rate keys on auto-reset #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/fairvisor/circuit_breaker.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ local tostring = tostring
-- Fixed 1-minute rolling window; TTL for rate keys. Configurable window could be added later.
local WINDOW_SIZE_SECONDS = 60
local WINDOW_TTL_SECONDS = 120
local SECONDS_PER_MINUTE = 60
local STATE_PREFIX = "cb_state:"
local RATE_PREFIX = "cb_rate:"
local OPEN_PREFIX = "open:"
Expand Down Expand Up @@ -116,7 +117,7 @@ function _M.check(dict, config, limit_key, cost, now)
local opened_at = _parse_opened_at(state_raw)
if opened_at then
if config.auto_reset_after_minutes > 0 then
local elapsed_minutes = (now - opened_at) / WINDOW_SIZE_SECONDS
local elapsed_minutes = (now - opened_at) / SECONDS_PER_MINUTE
if elapsed_minutes < config.auto_reset_after_minutes then
return {
tripped = true,
Expand All @@ -129,6 +130,12 @@ function _M.check(dict, config, limit_key, cost, now)
end

dict:delete(state_key)
-- Clear rate keys so the sliding-window estimator does not immediately
-- re-trip the breaker on the first post-reset request. Mirrors _M.reset().
local current_window_ar = floor(now / WINDOW_SIZE_SECONDS) * WINDOW_SIZE_SECONDS
local previous_window_ar = current_window_ar - WINDOW_SIZE_SECONDS
dict:delete(_M.build_rate_key(limit_key, current_window_ar))
dict:delete(_M.build_rate_key(limit_key, previous_window_ar))
else
return {
tripped = true,
Expand Down
Loading