Skip to content

fix(cost_budget): align 7d period start to Monday UTC #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
levleontiev merged 2 commits into from
Apr 12, 2026
+2 −2
Merged

fix(cost_budget): align 7d period start to Monday UTC #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a146c7c
fix(cost_budget): align 7d period to Monday UTC
levleontiev Apr 12, 2026
7fd2494
test(cost_budget): fix expected 7d period start to Monday
levleontiev Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/unit/features/cost_budget.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ Feature: Cost budget limiter module behavior

Scenario: computes weekly period boundary aligned to Monday UTC
When I compute period start for period "7d" at now 1770129000
Then the period start is 1769904000
Then the period start is 1769990400

Scenario: rejects unknown period in period start computation
When I compute period start for period "30m" at now 1770129000
Expand Down
2 changes: 1 addition & 1 deletion src/fairvisor/cost_budget.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function _M.compute_period_start(period, now)
end

if period == "7d" then
return floor((now - 259200) / 604800) * 604800 + 259200
return floor((now - 345600) / 604800) * 604800 + 345600
end

return nil, "unknown period"
Expand Down
Loading