Skip to content

Fixed double confirmation alert #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
homer2 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixed double confirmation alert #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions src/unsavedChanges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,22 +196,28 @@ angular.module('unsavedChanges', ['resettable'])

var eventsToWatchFor = unsavedWarningsConfig.routeEvent;

angular.forEach(eventsToWatchFor, function(aEvent) {
angular.forEach(eventsToWatchFor, function (aEvent) {
//calling this function later will unbind this, acting as $off()
var removeFn = $rootScope.$on(aEvent, function(event, next, current) {
var removeFn = $rootScope.$on(aEvent, function (event, next, current) {
unsavedWarningsConfig.log("user is moving with " + aEvent);
// @todo this could be written a lot cleaner!
if (!allFormsClean()) {
unsavedWarningsConfig.log("a form is dirty");
if (!confirm(unsavedWarningsConfig.navigateMessage)) {
unsavedWarningsConfig.log("user wants to cancel leaving");
event.preventDefault(); // user clicks cancel, wants to stay on page
if (unsavedWarningsConfig.hasConfirmed) {
unsavedWarningsConfig.log("user already confirmed, skipping confirmation for " + aEvent);
}
else {
// @todo this could be written a lot cleaner!
if (!allFormsClean()) {
unsavedWarningsConfig.log("a form is dirty");
if (!confirm(unsavedWarningsConfig.navigateMessage)) {
unsavedWarningsConfig.log("user wants to cancel leaving");
event.preventDefault(); // user clicks cancel, wants to stay on page
} else {
unsavedWarningsConfig.hasConfirmed = true;
unsavedWarningsConfig.log("user doesn't care about loosing stuff");
$rootScope.$broadcast('resetResettables');
}
} else {
unsavedWarningsConfig.log("user doesn't care about loosing stuff");
$rootScope.$broadcast('resetResettables');
unsavedWarningsConfig.log("all forms are clean");
}
} else {
unsavedWarningsConfig.log("all forms are clean");
}

});
Expand Down