fix: change private field from string to boolean in react-devtools-fusebox package.json#35862
Conversation
…sebox package.json Fixes facebook#35793 ## Problem The react-devtools-fusebox package.json has a malformed `private` field using a string value instead of a boolean: "private": "true" // ❌ Wrong (string) This violates the npm package.json specification which requires the `private` field to be a boolean: https://docs.npmjs.com/cli/v11/configuring-npm/package-json#private ## Impact This causes failures in package scanning and validation tools: - ScanCode.io pipeline failures (pkg:github/facebook/react@v19.2.1) - Type validation errors: '"true" value must be either True or False' - Non-compliance with npm specification Related upstream issues: - aboutcode-org/scancode.io#1986 - Pipeline failure report - aboutcode-org/scancode-toolkit#4631 - Root cause analysis ## Solution Change the `private` field to a boolean value: "private": true // ✅ Correct (boolean) This 1-character fix makes the package.json compliant with the npm specification and resolves scanning failures in downstream tools.
|
Hi @darshjme-codes! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Fixes #35793
Problem
The package.json has a malformed
privatefield using a string value instead of a boolean:This violates the npm package.json specification which requires the
privatefield to be a boolean.Impact
This causes failures in package scanning and validation tools:
pkg:github/facebook/react@v19.2.1'"true" value must be either True or False.'Related upstream issues:
While downstream tools are adding workarounds, the source data should comply with the npm specification.
Solution
Change the
privatefield to a boolean value:{ "name": "react-devtools-fusebox", "version": "0.0.0", - "private": "true", + "private": true, "license": "MIT", }Testing
"true"and booleantruebehave identically in npm, but tools rely on correct typing)Note: Issue reporter (@prashantsingh1819) offered to submit a PR but hasn't yet, so I'm submitting this fix to resolve the scanning failures.