Fix preserve-manual-memoization false positive with optional chaining deps#35859
Open
sleitor wants to merge 1 commit intofacebook:mainfrom
Open
Fix preserve-manual-memoization false positive with optional chaining deps#35859sleitor wants to merge 1 commit intofacebook:mainfrom
sleitor wants to merge 1 commit intofacebook:mainfrom
Conversation
… deps When a dependency array uses optional chaining (e.g. [obj?.id]), the compiler may infer a less specific dependency (e.g. obj) because optional chain lowering introduces conditionals. Previously this triggered a Subpath error, but the user's more specific optional dependency is semantically correct — using ?. acknowledges the conditionality and produces undefined when the base is nullish. This change treats the inferred-less-specific case as OK when the source dependency continues with an optional property access from where the inferred dependency ends. Fixes facebook#35577 Fixes facebook#35167
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a dependency array uses optional chaining (e.g.
[obj?.id]), the compiler may infer a less specific dependency (e.g.obj) because optional chain lowering introduces conditionals. Previously this triggered aSubpatherror ("Inferred less specific property than source"), but the user's more specific optional dependency is semantically correct — using?.acknowledges the conditionality and producesundefinedwhen the base is nullish.This change treats the inferred-less-specific case as OK when the source dependency continues with an optional property access from where the inferred dependency ends. Non-optional source deps that are more specific than inferred deps still correctly produce the Subpath error.
Test
Added
useCallback-optional-chaining-deptest fixture that reproduces the exact pattern from #35577. All 1712 existing tests pass.Fixes #35577
Fixes #35167