Wire native CSS parsing for transform#55677
Closed
NickGerleman wants to merge 3 commits intofacebook:mainfrom
Closed
Wire native CSS parsing for transform#55677NickGerleman wants to merge 3 commits intofacebook:mainfrom
NickGerleman wants to merge 3 commits intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
NickGerleman
force-pushed
the
export-D94052735
branch
3 times, most recently
from
48d626b to
d535536
Compare
NickGerleman
force-pushed
the
export-D94052735
branch
from
d535536 to
aaf3c6b
Compare
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94052735. |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 23, 2026
Summary: Gate `processTransform` behind `enableNativeCSSParsing()`. When the flag is on, CSS transform strings like `"rotate(45deg) scale(2)"` are parsed natively using the existing CSS transform parser instead of being preprocessed in JS. Changelog: [Internal] Differential Revision: D94052735
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 23, 2026
Summary: Gate `processTransform` behind `enableNativeCSSParsing()`. When the flag is on, CSS transform strings like `"rotate(45deg) scale(2)"` are parsed natively using the existing CSS transform parser instead of being preprocessed in JS. Changelog: [Internal] Differential Revision: D94052735
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 23, 2026
Summary: Gate `processTransform` behind `enableNativeCSSParsing()`. When the flag is on, CSS transform strings like `"rotate(45deg) scale(2)"` are parsed natively using the existing CSS transform parser instead of being preprocessed in JS. Changelog: [Internal] Differential Revision: D94052735
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 23, 2026
Summary: Gate `processTransform` behind `enableNativeCSSParsing()`. When the flag is on, CSS transform strings like `"rotate(45deg) scale(2)"` are parsed natively using the existing CSS transform parser instead of being preprocessed in JS. Changelog: [Internal] Differential Revision: D94052735
NickGerleman
force-pushed
the
export-D94052735
branch
from
aaf3c6b to
41fda2c
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 23, 2026
Summary: Pull Request resolved: facebook#55677 Gate `processTransform` behind `enableNativeCSSParsing()`. When the flag is on, CSS transform strings like `"rotate(45deg) scale(2)"` are parsed natively using the existing CSS transform parser instead of being preprocessed in JS. Changelog: [Internal] Differential Revision: D94052735
NickGerleman
force-pushed
the
export-D94052735
branch
from
41fda2c to
f8b998d
Compare
facebook#55674) Summary: Centralize gated ViewConfig processor attributes into exported constants in `ReactNativeStyleAttributes.js`. This is a pure refactor — no new behavior. When `enableNativeCSSParsing()` is on, the JS processor is bypassed and the raw value is sent directly to native. Exported attributes: `colorAttribute`, `filterAttribute`, `boxShadowAttribute`, `backgroundImageAttribute`, `backgroundSizeAttribute`, `backgroundPositionAttribute`, `backgroundRepeatAttribute`. All ViewConfig files now import these constants instead of inlining `{process: require(...)}` or feature flag checks. Changelog: [Internal] Reviewed By: jorge-cab Differential Revision: D94052734
Summary: `filterTypeFromString()` throws `std::invalid_argument` on unknown filter names, which crashes in `parseFilterRawValue` where it's called without try/catch. Change the return type to `std::optional<FilterType>` and return `std::nullopt` instead of throwing. Update callers in `FilterPropsConversions.h` to check the optional and gracefully return empty results. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D94052729
Summary: Gate `processTransform` behind `enableNativeCSSParsing()`. When the flag is on, CSS transform strings like `"rotate(45deg) scale(2)"` are parsed natively using the existing CSS transform parser instead of being preprocessed in JS. Changelog: [Internal] Reviewed By: jorge-cab Differential Revision: D94052735
NickGerleman
force-pushed
the
export-D94052735
branch
from
f8b998d to
a570239
Compare
|
This pull request has been merged in d0acce9. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in d0acce9 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Gate
processTransformbehindenableNativeCSSParsing(). When the flag is on, CSS transform strings like"rotate(45deg) scale(2)"are parsed natively using the existing CSS transform parser instead of being preprocessed in JS.Changelog: [Internal]
Differential Revision: D94052735