Suppress Warnings in generated classes#145
Open
Wavesonics wants to merge 8 commits intof2prateek:masterfrom
Open
Suppress Warnings in generated classes#145Wavesonics wants to merge 8 commits intof2prateek:masterfrom
Wavesonics wants to merge 8 commits intof2prateek:masterfrom
Conversation
These were mostly a problem with generics
Collaborator
|
@Wavesonics can you make the PR green please ? |
Author
|
Fun fact: You can use travis to fully compile and iterate on your code... Anyway, looks green now. |
Author
|
Any change to get this PR into the next release? |
Owner
|
@Wavesonics looks like the indentation is a bit off in a few places. |
Collaborator
|
@Wavesonics can you fix the indentation so that we can merge it ? |
Collaborator
|
The PR is targeting an older version of Dart. @Wavesonics can you reproduce the issue you are trying to solve with the version 3.0.1? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were mostly a problem with generics