feat(compute): add --reverse-dns flag to create command#816
Open
nhedger wants to merge 3 commits intoexoscale:masterfrom
Open
feat(compute): add --reverse-dns flag to create command#816nhedger wants to merge 3 commits intoexoscale:masterfrom
--reverse-dns flag to create command#816nhedger wants to merge 3 commits intoexoscale:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Disclosure:
Description
Closes #564
This PR adds a
--reverse-dnsflag to thecompute instance createcommand.The implementation follows the same approach already used by
compute instance update: after the instance is created and the operation completes successfully, the CLI applies reverse DNS through the dedicated reverse-DNS API endpoint before returning the final instance output.Test coverage was added for both the CLI surface and the API-backed lifecycle:
compute instance create --helpexposes--reverse-dnscompute instance show, then deletes itOne API detail worth noting is that the returned reverse DNS value includes a trailing dot, so the API test matches that behavior.
Checklist
(For exoscale contributors)
CHANGELOG.md)Testing
go build -mod=vendor -o bin/exo .go test ./cmd/...go test -C tests/e2e -run 'TestScriptsLocal/compute_instance_create_flags' -vgo test -C tests/e2e -tags=api -run 'TestScriptsAPI/instance_create_reverse_dns' -v