Skip to content

fix: stop shipping dev artefacts in make package ZIP (#50) #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eXeLearningProject merged 2 commits into from
May 11, 2026
Merged

fix: stop shipping dev artefacts in make package ZIP (#50) #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0a231c
fix: stop shipping dev artefacts in make package ZIP (#50)
erseco May 9, 2026
b7e73a5
Merge branch 'main' into 50-no-unnecessary-files-in-package
ignaciogros May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .distignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@
.github
.gitignore
.aider*
.claude
.DS_Store
.distignore
.editor-version
.env
.env.dist
.omc
exelearning/
vendor/
node_modules/
Expand All @@ -19,4 +23,5 @@ composer.phar
CLAUDE.md
AGENTS.md
scripts/
NUL
mod_exeweb-*.zip
12 changes: 12 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,15 @@ Uses Moodle's file API — packages stored in `mod_exeweb/package` filearea, exp
- `make package RELEASE=X.Y.Z` updates `version.php`, creates ZIP excluding files in `.distignore`, then restores dev values
- GitHub Actions `release.yml` triggers on git tags: fetches editor, builds, packages, uploads to GitHub Release
- `check-editor-releases.yml` runs daily to auto-release when new editor versions appear

## Twin-plugin checks (mod_exeweb ↔ mod_exescorm)

`mod_exeweb` and [`mod_exescorm`](https://github.com/exelearning/mod_exescorm) share large amounts of code, history, and bug surface (embedded editor, action bar, packaging pipeline, online callbacks, etc.). **Before closing a fix, always cross-check the sibling plugin:**

1. **Search the sibling repo for a matching issue.** Examples:
- `gh issue list --repo exelearning/mod_exescorm --search "<keywords>"`
- `gh issue list --repo exelearning/mod_exescorm --state all --search "<keywords>"` (also closed)
If a matching issue exists, plan to fix both at once and link them in the PR bodies.
2. **Even if no twin issue is open**, audit the sibling for the same root cause: most bugs reproduce on both sides because the relevant code is intentionally near-identical.
3. When the bug applies to both, **open a PR in each repo** with the parallel fix and **cross-reference the sibling PR** in the body (e.g. `Sibling PR: exelearning/mod_exescorm#65`). Use parallel branch names and commit messages so the diffs are easy to compare.
4. If after auditing only one plugin is affected, document why in the PR body so a future reader doesn't repeat the search.
Loading