fix: show Edit button in popup/new/open/frame display modes#46
Open
fix: show Edit button in popup/new/open/frame display modes#46
Conversation
For Display modes other than Embed, view.php delegated to exeweb_print_workaround() / exeweb_display_frame(), which never rendered the action_bar template. Teachers therefore had no Edit button and could only view the package. Render the action_bar in both code paths so the Edit (online or embedded editor) action is available in every Display mode. Also make the embedded editor modal attach to the topmost same-origin window. When the Edit button is clicked from inside a small frame (FRAME mode top frame, or any embedded iframe context), the overlay previously rendered inside the cramped frame and got stuck near the bottom with the close button out of reach. The modal now spans the full viewport. Refs #43
3 tasks
ignaciogros
requested changes
May 6, 2026
Collaborator
ignaciogros
left a comment
ignaciogros
left a comment
There was a problem hiding this comment.
In the "Iframe" options, the fullscreen and the "Edit in eXeLearning" button are not working.
I don’t really see what this option adds, because "Embed" also uses an iframe. Should we remove it?
If we decide to keep it, I'llfix a few minor presentation issues once the functionality is fixed.
Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #43.
mod_exeweb/action_bartemplate (which carries the eXeLearning Online / embedded editor Edit button) inexeweb_print_workaround()and in the FRAME-mode top frame. Previously the Edit button only existed inembed_general.mustache, so any teacher whose activity used In popup / Open / New window / In frame had no way to edit the package from the activity view.Test plan
exewebactivity with Display = In pop-up and confirm the Edit button is visible on the activity view and opens the editor modal.Moodle Playground Preview
The changes in this pull request can be previewed and tested using a Moodle Playground instance.