Splitted up common.py by tomuben · Pull Request #447 · exasol/integration-test-docker-environment

tomuben · 2025-02-10T18:37:21Z

fixes #430

All Submissions:

Is the title of the Pull Request correct?
Is the title of the corresponding issue correct?
Have you updated the changelog?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Are you mentioning the issue which this PullRequest fixes ("Fixes...")
Are the CLI usage examples up to date?

Details

Created module "models"
Moved lib/config -> lib/models/config
Moved lib/data -> lib/models/data
Moved libapi/api_errors.py -> lib/models/api_errors.py
Extracted run_tasks.py from common.py and moved to lib/base/run_tasks.py
Extracted decorator functions from common.py -> lib/utils
Extracted rest from common.py in appropriate files

tkilias · 2025-02-10T20:40:28Z



 def import_build_steps(flavor_path: Tuple[str, ...]):
+    # TODO Move to script-languages-container-tools: https://github.com/exasol/script-languages-container-tool/issues/268


Was confused for the moment, because the framework for building the docker images is used also for the test container, but it is only about the build steps file.

However, more correct would be probably extracting the docker images build part into a repo and the import with it

Hm, I see that the flavor_path and and FlavorsBaseTask and so on, which are tasks specific for exaslct are also here. So I guess you are right, and it's does not make sense to move this single function only then to exaslct. I will close exasol/script-languages-container-tool#268

However FlavorBaseTask doesn't belong here, contrary to the import build steps. Also the test env should not know about flavors, that should be added in slct

tkilias · 2025-02-10T20:49:55Z

 module = [ "luigi.*", "docker.*", "humanfriendly", "configobj", "toml", "netaddr", "joblib.testing", "networkx",
            "fabric", "requests", "pyexasol", "paramiko.ssh_exception", "six", "jsonpickle", "exasol.toolbox.*",
-            "paramiko", "exasol"]
+            "paramiko", "exasol", "networkx.classes"]


Do we still need the exasol override, if yes then the question which repo is the offender

It's https://github.com/exasol/error-reporting-python

Then we should fix it

=> See exasol/error-reporting-python#58

2. Moved common.py -> base/import_build_step.py 3. Moved run_task.py -> base/run_task.py

tkilias · 2025-02-11T00:37:23Z

 from exasol_integration_test_docker_environment.cli.cli import cli
 from exasol_integration_test_docker_environment.lib import api
-from exasol_integration_test_docker_environment.lib.api.api_errors import HealthProblem
+from exasol_integration_test_docker_environment.lib.models.api_errors import (


This looks like you might change the external interface, because moving externally used files might break imports. i have the feeling, we really need to set up a check for potential API breakage. https://github.com/StardustDL/aexpy

Increased Major version to 4.0.0

Co-authored-by: Torsten Kilias <tkilias@users.noreply.github.com>

tomuben added 2 commits February 10, 2025 15:36

#430: Splitted up common.py

335f40b

Updared unreleased.md

1b16f0a

tomuben had a problem deploying to manual-approval February 10, 2025 18:37 — with GitHub Actions Failure

Fixed format check and type check

06d99b4

tomuben had a problem deploying to manual-approval February 10, 2025 18:49 — with GitHub Actions Failure

Fixed type check

bc87a38

tomuben temporarily deployed to manual-approval February 10, 2025 18:54 — with GitHub Actions Inactive

Fixed test_base_task_cleanup.py

7a3c106

tomuben had a problem deploying to manual-approval February 10, 2025 20:40 — with GitHub Actions Failure

Fixed test_base_task_cleanup.py

bbc88af

tomuben temporarily deployed to manual-approval February 10, 2025 20:42 — with GitHub Actions Inactive

tkilias reviewed Feb 10, 2025

View reviewed changes

1. Moved api_errors.py -> models/

7e9d4b4

2. Moved common.py -> base/import_build_step.py 3. Moved run_task.py -> base/run_task.py

tomuben had a problem deploying to manual-approval February 10, 2025 21:27 — with GitHub Actions Failure

Moved lib/data -> lib/models/data

771b454

tomuben had a problem deploying to manual-approval February 10, 2025 21:38 — with GitHub Actions Failure

Moved lib/config -> lib/models/config

c34fe33

tomuben temporarily deployed to manual-approval February 10, 2025 21:43 — with GitHub Actions Inactive

tkilias reviewed Feb 11, 2025

View reviewed changes

Updated version to 4.0.0

330f32a

tomuben had a problem deploying to manual-approval February 12, 2025 13:42 — with GitHub Actions Failure

Fixed version.py

b2998cc

tomuben temporarily deployed to manual-approval February 12, 2025 13:45 — with GitHub Actions Inactive

tkilias reviewed Feb 13, 2025

View reviewed changes

Comment thread doc/changes/unreleased.md Outdated

Update doc/changes/unreleased.md

2702d56

Co-authored-by: Torsten Kilias <tkilias@users.noreply.github.com>

tomuben temporarily deployed to manual-approval February 13, 2025 12:07 — with GitHub Actions Inactive

tkilias approved these changes Feb 13, 2025

View reviewed changes

tomuben merged commit 734f689 into main Feb 13, 2025

tomuben deleted the refactoring/430_split_common branch February 13, 2025 14:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Splitted up common.py#447

Splitted up common.py#447
tomuben merged 12 commits intomainfrom
refactoring/430_split_common

tomuben commented Feb 10, 2025 •

edited

Loading

Uh oh!

tkilias Feb 10, 2025

Uh oh!

tkilias Feb 10, 2025

Uh oh!

tomuben Feb 10, 2025

Uh oh!

tkilias Feb 10, 2025

Uh oh!

tkilias Feb 10, 2025

Uh oh!

tomuben Feb 10, 2025

Uh oh!

tkilias Feb 10, 2025

Uh oh!

tomuben Feb 11, 2025

Uh oh!

tkilias Feb 11, 2025

Uh oh!

tomuben Feb 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		def import_build_steps(flavor_path: Tuple[str, ...]):
		# TODO Move to script-languages-container-tools: https://github.com/exasol/script-languages-container-tool/issues/268

Conversation

tomuben commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Details

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tomuben commented Feb 10, 2025 •

edited

Loading