fix: propagate and handle NO_FLIGHT_FOUND API errors properly#440
Open
VQToan wants to merge 1 commit into
Open
fix: propagate and handle NO_FLIGHT_FOUND API errors properly#440VQToan wants to merge 1 commit into
VQToan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #275
Description
Preserves structured purchase-validation failures from the API route to the client. This surfaces specific messages like
No matching flight foundinstead of a generic purchase failure, which occurs when the API route collapses validation failures into generic HTTP 500 errors or unhandled client-side exceptions.Changes
FlightNotFoundErrorandInconsistentFlightDataErrortoerrors.ts.purchase/route.tsto throw these typed errors duringvalidateFlightPlanwhen flight stats are missing or mismatched, and to return structured JSON responses with specific error codes.use_local_api.tsxto parse these JSON responses and throwErrorinstances annotated witherr.reason.use_application.tsx'scatchblock to look forerr.reason === Reason.NO_FLIGHT_FOUNDandReason.INCONSISTENT_DATA, dispatching the exact translated UI error messages.setErrorcouldn't take areasonfield inflightData.ts.This PR was created with AI assistance.