This repository was archived by the owner on Mar 31, 2021. It is now read-only.
Fixed intermittent crashes in fullscreen zooming#20
Open
kevwkev wants to merge 1 commit intoethan605:masterfrom
kevwkev:master
Open
Fixed intermittent crashes in fullscreen zooming#20kevwkev wants to merge 1 commit intoethan605:masterfrom kevwkev:master
kevwkev wants to merge 1 commit intoethan605:masterfrom
kevwkev:master
Conversation
When zooming in and out multiple times quickly on an image in
fullscreen mode, the example application crashes intermittently.
stops at line:
"for (UIPhotoContainerView *subView in reusableViews) {" from
"UIPhotoGalleryView.m"
breakpoint analyzer:
#0 0x38dd9cc0 in objc_exception_throw ()
#1 0x2e4c99f0 in __NSFastEnumerationMutationHandler ()
#2 0x0009d61c in -[UIPhotoGalleryView scrollViewDidScroll:] at
UIPhotoGallery/UIPhotoGalleryView.m:172
#3 0x311026e4 in -UIScrollView(UIScrollViewInternal) _notifyDidScroll
|
It isn't good solution. To fix this issue, we just change the calculate of new page int nextPage = (NSInteger)ceilf(newPage); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When zooming in and out multiple times quickly on an image in
fullscreen mode, the example application crashes intermittently.
stops at line:
"for (UIPhotoContainerView *subView in reusableViews) {" from
"UIPhotoGalleryView.m"
breakpoint analyzer:
#0 0x38dd9cc0 in objc_exception_throw ()
#1 0x2e4c99f0 in __NSFastEnumerationMutationHandler ()
#2 0x0009d61c in -[UIPhotoGalleryView scrollViewDidScroll:] at
UIPhotoGallery/UIPhotoGalleryView.m:172
#3 0x311026e4 in -UIScrollView(UIScrollViewInternal) _notifyDidScroll