This repository was archived by the owner on Mar 31, 2021. It is now read-only.
Some changes for real scrolling to initialIndex and using several galleries#18
Open
Bogdan-Stasjuk wants to merge 4 commits intoethan605:masterfrom
Open
Some changes for real scrolling to initialIndex and using several galleries#18Bogdan-Stasjuk wants to merge 4 commits intoethan605:masterfrom
Bogdan-Stasjuk wants to merge 4 commits intoethan605:masterfrom
Conversation
…y property UIPhotoGalleryView *vPhotoGallery. Public vPhotoGallery is required when using several galleries for identify concrete gallery in UIPhotoGalleryDataSource methods.
…nimated". Removed method - (void)setInitialIndex:(NSInteger)initialIndex. Added UIViewController's method “viewDidAppear:” with call of setInitialIndex:animated: from UIPhotoGalleryView for real scrolling to initial index. Added "self.vPhotoGallery.hidden = YES" in "viewWillDisappear:" for quick disappearance.
…GalleryViewController
…scrolling to initialIndex when setupMainScrollView is called from layoutSubviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we using list of galleries it is handy to have public link on UIPhotoGalleryView's instance for identify concrete gallery in UIPhotoGalleryDataSource methods.
For real scrolling to initialIndex in UIPhotoGalleryViewController I added call of setInitialIndex:animated: from viewDidAppear:.
After poping UIPhotoGalleryViewController's instance I see previous image from vPhotoGallery above current viewController about a second in case of images count is more than 1 and current index is more than 0. To solve this issue I added "self.vPhotoGallery.hidden = YES" in "viewWillDisappear:".