Multiple package repos in config.yaml#294
Open
msimberg wants to merge 13 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends config.yaml to accept not only
... packages: repo: https://github.com/foo/spack-packages.git commit: abcdefbut also multiple repos:
... packages: myrepo: repo: https://github.com/bar/other-packages.git commit: fedcba path: path/to/repo builtin: repo: https://github.com/foo/spack-packages.git commit: abcdefOrder of repos is significant in the same way it's significant in spack config files (https://spack.readthedocs.io/en/latest/repositories.html#search-order-and-overriding-packages). Packages from repos higher up on the list take precedence.
I made a small change so that there are also two implicit repos (currently on main there's one:
alps). A reporecipeexists if and only if there are packages in the recipe.alpsstill exists, but doesn't have the recipe packages. The example above would produce the following list of repos:recipealpsmyrepobuiltinCurrently there's no enforcement that the repo entry has the same name as the repo namespace (similar to spack itself, if I understand it correctly). Is this ok?
There's an optional
pathproperty that can be used to point to a non-default subdirectory within the cloned git repo. For spack-packages this is always inrepos/spack_repo/builtin, so the default isrepos/spack_repo/{name}. In spack-packages there is an index file https://github.com/spack/spack-packages/blob/develop/spack-repo-index.yaml which could be used to locate all the package repos within a git repo. Spack uses this when it clones package repos through git. For now I decided it's overkill to support that. Thoughts?