Skip to content

fix: OTP29 compilation#2994

Open
MarkoMin wants to merge 1 commit intoerlang:mainfrom
MarkoMin:fix_otp29_compilation
Open

fix: OTP29 compilation#2994
MarkoMin wants to merge 1 commit intoerlang:mainfrom
MarkoMin:fix_otp29_compilation

Conversation

@MarkoMin
Copy link
Copy Markdown
Contributor

OTP 29 brought a new compilation warning to discourage use of catch .... There are several places where this occurs in rebar3, relx and erlware_commons which causes an error because only erlware_commons is compiled with warning_as_errors option.

I don't see why that dep should be treated differently, because IMHO that should either be enabled for all deps or for none.

I'll open separate MR-s to fix warning in rebar3, relx and erlware_commons, but I think that warning_as_errors should be removed anyways because it isn't forward compatible

@tsloughter
Copy link
Copy Markdown
Collaborator

Thanks, I actually already have a PR for this but forgot to merge it #2983

@MarkoMin
Copy link
Copy Markdown
Contributor Author

I saw that and agree with it, but that warnings_as_errors flag should be removed anyways to prevent situations like this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants