Open
Conversation
Collaborator
|
Thanks, I actually already have a PR for this but forgot to merge it #2983 |
Contributor
Author
|
I saw that and agree with it, but that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OTP 29 brought a new compilation warning to discourage use of
catch .... There are several places where this occurs inrebar3,relxanderlware_commonswhich causes an error because onlyerlware_commonsis compiled withwarning_as_errorsoption.I don't see why that dep should be treated differently, because IMHO that should either be enabled for all deps or for none.
I'll open separate MR-s to fix warning in
rebar3,relxanderlware_commons, but I think thatwarning_as_errorsshould be removed anyways because it isn't forward compatible