configure: use a floating-point argument in isfinite checks#10965
Merged
bjorng merged 1 commit intoerlang:masterfrom Apr 9, 2026
Merged
configure: use a floating-point argument in isfinite checks#10965bjorng merged 1 commit intoerlang:masterfrom
bjorng merged 1 commit intoerlang:masterfrom
Conversation
The configure probes in erts and common_test/test_server currently call isfinite(0). On platforms where isfinite is provided as a macro, this can fail to compile because the argument is not a floating-point value. Use isfinite(0.0) instead. This matches the expected API usage and fixes the configure checks on Solaris.
Contributor
CT Test Results 4 files 183 suites 2h 3m 25s ⏱️ Results for commit 34bfca1. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
|
Contributor
|
Hello! Thanks for the PR! Would you please sign the CLA? |
garazdawi
approved these changes
Apr 7, 2026
Contributor
|
Thanks for your pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configure probes in erts and common_test/test_server currently call isfinite(0). On platforms where isfinite is provided as a macro, this can fail to compile because the argument is not a floating-point value.
Use isfinite(0.0) instead. This matches the expected API usage and fixes the configure checks on Solaris.