Merged
Conversation
Contributor
CT Test Results 2 files 100 suites 1h 8m 17s ⏱️ Results for commit eb3d0a3. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
essen
approved these changes
Mar 29, 2026
jhogberg
previously approved these changes
Mar 30, 2026
jhogberg
reviewed
Mar 30, 2026
Co-authored-by: "John Högberg" <john@erlang.org>
jhogberg
force-pushed
the
rickard/zstd-flush-fix
branch
from
8413ea4 to
eb3d0a3
Compare
jhogberg
added
the
testing
essen
approved these changes
Apr 20, 2026
jhogberg
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
zstd:flush/2introduced in #10511 @essen @jhogbergIn debug mode, the zstd NIF reduce the chunk size to 5 which causes the
zstd:flush/2function in thecstreamtestcase to return{flush, _}which causes the testcase to fail.{flush, _}is not a valid return value according to the docs.This PR prevents the testcase failure, but the change in this PR is a guess of what the
flush/2function should have done. I'm not sure if this fix is correct or complete.