ssl: Preserve inet option order in emulated_options

[zuiderkwast]

The emulated_options/3 function in tls_socket and dtls_socket used a prepend accumulator pattern without reversing the result, causing inet options to be reversed when passed to gen_tcp:connect/gen_udp:open.

This broke the inet_backend option which must be the first option in the list according to gen_tcp and gen_udp documentation.

Fix by reversing the Inet accumulator before returning.

Before

Erlang/OTP 28 [erts-16.1.2] [source] [64-bit] [smp:14:14] [ds:14:14:10] [async-threads:1] [jit] [dtrace]

Eshell V16.1.2 (press Ctrl+G to abort, type help(). for help)
1> application:ensure_all_started(ssl).
{ok,[crypto,asn1,public_key,ssl]}
2> ssl:connect("127.0.0.1", 12345, [{inet_backend, socket}, {recbuf, 32768}, {verify, verify_none}]).
{error,{badarg,"gen_tcp:connect(\"127.0.0.1\", 12345, [{recbuf,32768},{inet_backend,socket}], infinity)"}}
3> ssl:connect("127.0.0.1", 12345, [{inet_backend, socket}, {recbuf, 32768}, {protocol, dtls}, {verify, verify_none}], 1000).
** exception exit: badarg
     in function  inet_udp:open/2 (inet_udp.erl:56)
     in call from dtls_socket:connect/4 (dtls_socket.erl:92)
     in call from ssl:connect/4 (ssl.erl:2269)

After

Erlang/OTP 29 [RELEASE CANDIDATE 2] [erts-16.3] [source-c77b8b0c89] [64-bit] [smp:14:14] [ds:14:14:10] [async-threads:1] [jit]

Eshell V16.3 (press Ctrl+G to abort, type help(). for help)
1> application:ensure_all_started(ssl).
{ok,[crypto,asn1,public_key,ssl]}
2> ssl:connect("127.0.0.1", 12345, [{inet_backend, socket}, {recbuf, 32768}, {verify, verify_none}]).
{error,econnrefused}
3> ssl:connect("127.0.0.1", 12345, [{inet_backend, socket}, {recbuf, 32768}, {protocol, dtls}, {verify, verify_none}], 1000).
{error,timeout}

[github-actions]

CT Test Results

    2 files     66 suites   26m 20s ⏱️
  819 tests   773 ✅  46 💤 0 ❌
4 276 runs  3 319 ✅ 957 💤 0 ❌

Results for commit c380a0d.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• No Windows Installer found

// Erlang/OTP Github Action Bot

[IngelaAndin]

@zuiderkwast Please base it so that it can be target for maint. (Or retarget if that is already the case) I think it is a bug that it does not work so we want to fix it for maint too.

The base branch was changed.

[sverker]

@IngelaAndin @zuiderkwast

Does not compile:

dtls_socket.erl:237:7: syntax error before: '{'
       {Inet ++ internal_inet_values(), Emulated}
       ^

[zuiderkwast]

Sorry for the typo(s). Shall I squash the commits and force-push?

[IngelaAndin]

@zuiderkwast Yes please could also make sure that you base your branch on OTP-28.4.1-label as then I can piggyback it on an un-planned OTP-28 patch, as there are no more planned patches for 28 track. (It can still be targeted at maint here as it should merge cleanly).

[zuiderkwast]

@IngelaAndin Done. It's based on the OTP-28.4.1 tag now.