sim,python: Document and name the hypercall exit APIs#83
Open
erin-le wants to merge 1 commit into
Open
Conversation
- add "include/gem5/exit_hypercalls.hh" and expand it into the C++ enum, the `kExitHypercall*` constants, the pybind enum, and the guest-facing `M5_HYPERCALL_*` macros so every layer pulls its IDs from the same source, - expose the enum to Python, allow `ExitHandler`s to be registered via enums/strings, add a `hypercall=` alias for the old `hypercall_num` argument, and update the sample configs/tests to use the descriptive names - flesh out the "sim_exit.hh" docs so it is clear when to use the legacy `exitSimLoop*` helpers, the transitional `exitSimLoopWithHypercall`, or the new `exitSimulationLoop*` APIs
|
I added these labels: configs,python,sim,stdlib,tests,util |
erin-le
force-pushed
the
labeler-action
branch
3 times, most recently
from
4c4507a to
a85cdb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add "include/gem5/exit_hypercalls.hh" and expand it into the C++ enum, the
kExitHypercall*constants, the pybind enum, and the guest-facingM5_HYPERCALL_*macros so every layer pulls its IDs from the same source,expose the enum to Python, allow
ExitHandlers to be registered via enums/strings, add ahypercall=alias for the oldhypercall_numargument, and update the sample configs/tests to use the descriptive namesflesh out the "sim_exit.hh" docs so it is clear when to use the legacy
exitSimLoop*helpers, the transitionalexitSimLoopWithHypercall, or the newexitSimulationLoop*APIs