Fix reverse_fold without concepts#76
Open
jkuebart wants to merge 2 commits intoericniebler:masterfrom
Open
Conversation
Author
|
I have since discovered that the tests expect the invocation as written, hence only the documentation needs to be changed ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe there's an error in the
reverse_foldimplementation in caseMETA_CONCEPTis not set.compose1_as defined byfoldpasses the functor's argument as the first argument to the function. Wherecompose1_is used in the implementation ofreverse_fold, I believe we want to pass it on as the second function argument. Anyway, that's how I interpretFun(A_N, State_N+1)in the documentation.Without this change, I get
My compiler is