Skip to content

Fixed a bug with multiple pages. Added a Content tab. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeffreyVest wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Fixed a bug with multiple pages. Added a Content tab. #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ <h2 class="no-support">Your browser doesn't support Drag and Drop, or some other
</tfoot>
<tbody>
<tr ng-class="getSelectedRow($index)" class="revealed network-item network-type-{{entry.name}}" data-id="{{entry.id}}" ng-repeat="entry in page.entries | filter:query | filter:type | orderBy:predicate:reverse">
<td class="name-column" ng-click="showDetails($index)"><div title="{{entry.url}}"><img class="icon">{{entry.parsedURL.lastPathComponent}}<div class="network-cell-subtitle">{{entry.folder}}</div></div></td>
<td class="name-column" ng-click="showDetails($index, entry)"><div title="{{entry.url}}"><img class="icon">{{entry.parsedURL.lastPathComponent}}<div class="network-cell-subtitle">{{entry.folder}}</div></div></td>
<td class="method-column"><div title="{{entry.method}}">{{entry.method}}</div></td>
<td class="status-column"><div title="{{entry.status}} {{entry.statusText}}">{{entry.status}}<div class="network-cell-subtitle">{{entry.statusText}}</div></div></td>
<td class="type-column"><div title="{{entry.mimeType}}">{{entry.mimeType}}</div></td>
Expand Down Expand Up @@ -243,6 +243,7 @@ <h2 class="no-support">Your browser doesn't support Drag and Drop, or some other
<div ng-click="showTab(1)" ng-class="getTab(1)" class="tabbed-pane-header-tab selected"><span class="tabbed-pane-header-tab-title" title="">Headers</span></div>
<div ng-click="showTab(2)" ng-class="getTab(2)" class="tabbed-pane-header-tab"><span class="tabbed-pane-header-tab-title" title="">Cookies</span></div>
<div ng-click="showTab(3)" ng-class="getTab(3)" class="tabbed-pane-header-tab"><span class="tabbed-pane-header-tab-title" title="">Timing</span></div>
<div ng-click="showTab(4)" ng-class="getTab(4)" class="tabbed-pane-header-tab"><span class="tabbed-pane-header-tab-title" title="">Content</span></div>
</div>
</div>
</div>
Expand Down Expand Up @@ -387,6 +388,9 @@ <h2 class="no-support">Your browser doesn't support Drag and Drop, or some other
</tr>
</table>
</div>
<div ng-class="getVisibleTab(4)" class="resource-timing-view">
<p><pre>{{selectedEntry._entry.response.content.text}}</pre></p>
Copy link
Copy Markdown
Collaborator

@cvan cvan Jan 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contentText should probably be added here: https://github.com/ericduran/chromeHAR/blob/master/js/libs/HAREntry.js#L24

Copy link
Copy Markdown
Collaborator

@cvan cvan Jan 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why wrap a <pre> with a <p>?

</div>
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions js/controllers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@
$('.response.children').toggleClass('expanded');
};

$scope.showDetails = function(i) {
$scope.showDetails = function(i, entry) {
$scope.selectedRow = i;
$scope.selectedEntry = $scope.entries[i];
$scope.selectedEntry = entry;

var $leftView = $('.split-view-sidebar-left');
$('#network-views').removeClass('hidden');
Expand Down