Skip to content

Implement test for trie-join dead branch pruning #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
erdos wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Implement test for trie-join dead branch pruning #4

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e834673
Implement test for trie-join dead branch pruning
erdos May 10, 2026
b187b9b
Update triejoin_test.clj
erdos May 10, 2026
4b987b3
Update triejoin_test.clj
erdos May 10, 2026
f02ae3b
Update triejoin_test.clj
erdos May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions test/erdos/algo/leapfrog/triejoin_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,21 @@
(is (= 8 (-> seeked ->next (->seek 8) get-key)))))))


(deftest nested-trie-join-prunes-dead-branches
;; Regression: when an inner trie-join's leapfrog matches at depth d
;; but trie-open at d→d+1 fails, the outer must propagate that nil.
;; Falling back to the stale inner iter would leak its d-level key
;; into the outer's later leapfrogs and emit a phantom tuple with the
;; entity id leaking into a sibling's slot.
(let [inner (trie-join [:e :a] [(test-trie-iter [:e :a] [[1 :ok] [2 :no]])
(test-trie-iter [:a] [[:ok]])])
sib (test-trie-iter [:e :x] [[1 10] [2 20]])
outer (trie-join [:e :a :x] [inner sib])]
;; Only e=1 has :a=:ok. Without the fix, e=2 leaks as the phantom
;; {:e 2 :a 2 :x 20} — :a slot filled with the stale entity id.
(is (= [{:e 1 :a :ok :x 10}] (relations outer)))))


(def exponents
(test-trie-iter [:n1 :n2 :n3]
[[1 1 1]
Expand Down
Loading