Skip to content

Add meck:capture(..., result)#250

Open
rlipscombe wants to merge 2 commits intoeproxus:masterfrom
rlipscombe:rl/meck-capture-result
Open

Add meck:capture(..., result)#250
rlipscombe wants to merge 2 commits intoeproxus:masterfrom
rlipscombe:rl/meck-capture-result

Conversation

@rlipscombe
Copy link
Copy Markdown
Contributor

See #249

I'm not sure whether we want to deprecate the use of meck_history:result(), so I only changed one of the unit tests to use the changed meck:capture().

Let me know what direction you prefer, and I'll change the PR.

@eproxus
Copy link
Copy Markdown
Owner

eproxus commented Nov 12, 2024

@rlipscombe Thanks! Since result already exists and has the signature it has, I don't think it is too much of a stretch to allow returning the return value of a call too. What do you think about changing it to return_value instead? That matches the language in the Erlang documentation more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants