Adjusting string sizing for longer path names#36
Merged
keenanlang merged 3 commits intomasterfrom Apr 29, 2026
Merged
Conversation
anjohnson
reviewed
Feb 19, 2026
anjohnson
reviewed
Feb 20, 2026
Comment on lines
57
to
61
| record(waveform, "$(P)saveData_fullPathName") { | ||
| field(DTYP, "Soft Channel") | ||
| field(NELM, "100") | ||
| field(NELM, "512") | ||
| field(FTVL, "CHAR") | ||
| } |
Member
There was a problem hiding this comment.
Did you miss this record intentionally?
Member
Author
There was a problem hiding this comment.
That has always been a waveform, so I didn't necessarily want to change it and potentially affect functionality beyond what was asked for. But if the recommendation is to phase out waveforms, I will change it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #35, updates the fileSystem, subDir, and baseName fields to be able to handle up to 256 characters, rather than the <40 they previously did.
fullPathName is similarly increased to 512 characters.