add NestedForm integration#146
Open
alberto-bottarini wants to merge 1 commit intoepartment:masterfrom
Open
Conversation
NoahNxT
approved these changes
Dec 29, 2021
Contributor
|
LGTM, tested locally and no issues/bugs found |
NoahNxT
reviewed
Dec 29, 2021
Contributor
NoahNxT
left a comment
NoahNxT
left a comment
There was a problem hiding this comment.
LGTM, no issues/bugs found locally
Collaborator
|
I fixed conflicts in PR #200. This fix is very important. Please consider accepting |
|
I up this, need it functioning asap. |
pitylee
approved these changes
Jan 13, 2022
TheSETJ
approved these changes
Feb 1, 2022
Author
|
Any news? |
Collaborator
|
I wrote email to author. Unfortunately without an answer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nova Nested Form is a useful package to create related resource inline using a cool UX.
This package has some problem if it contains a DependencyContainer field.
This PR allow these 2 packages to cooperate.
NestedForm uses a custom field syntax for nested purpose (based on PHP square bracket array syntax).
This PR change standard behavior of DependencyContainer to use this syntax if it used inside of a NestedForm.
It is obviously completely retro-compatible.
It fixes these PRs
yassilah/laravel-nova-nested-form#26
yassilah/laravel-nova-nested-form#114