Skip to content

Add support for nova-grid-system#122

Open
happyDemon wants to merge 2 commits intoepartment:masterfrom
happyDemon:feature-dependency-container-compat
Open

Add support for nova-grid-system#122
happyDemon wants to merge 2 commits intoepartment:masterfrom
happyDemon:feature-dependency-container-compat

Conversation

@happyDemon
Copy link
Copy Markdown

@happyDemon happyDemon commented Jul 13, 2020

add support for https://github.com/codenco-dev/nova-grid-system (remove the unneeded container)
also added field.class to the main container element

@happyDemon happyDemon changed the title Feature dependency container compatibility Add support for nova-grid-system Jul 13, 2020
@Slgoetz
Copy link
Copy Markdown

Slgoetz commented Aug 21, 2020

Would love to see this roll out in the next release!

@wize-wiz
Copy link
Copy Markdown
Contributor

@happyDemon I'll have a look the next coming days

@ragingdave
Copy link
Copy Markdown
Collaborator

Took a look here and I don't see anywhere in the nova code or in the nova-grid-system that adds a field.class property. Where specifically is that coming from? I don't disagree the addtl div is probably not required, but adding something that's field specific feels very specific to someone's specific usage.
Also if you do want to move forward, if you can remove the dist js you updated here. We will build prior to the next release.

@corgalore
Copy link
Copy Markdown

@happyDemon, this can get merged if you remove the compiled JS file (field.js) from the PR. Would love to have this right now.

@scramatte
Copy link
Copy Markdown

Hello, I need it for my project. Please fix PR to merge it ASAP. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants