Add support for nova-grid-system#122
Open
happyDemon wants to merge 2 commits intoepartment:masterfrom
Open
Conversation
|
Would love to see this roll out in the next release! |
Contributor
|
@happyDemon I'll have a look the next coming days |
Collaborator
|
Took a look here and I don't see anywhere in the nova code or in the nova-grid-system that adds a field.class property. Where specifically is that coming from? I don't disagree the addtl div is probably not required, but adding something that's field specific feels very specific to someone's specific usage. |
|
@happyDemon, this can get merged if you remove the compiled JS file (field.js) from the PR. Would love to have this right now. |
|
Hello, I need it for my project. Please fix PR to merge it ASAP. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for https://github.com/codenco-dev/nova-grid-system (remove the unneeded container)
also added
field.classto the main container element