Try to read cover art from file in music_dir#131
Draft
kastdeur wants to merge 1 commit intoeonpatapon:masterfrom
Draft
Try to read cover art from file in music_dir#131kastdeur wants to merge 1 commit intoeonpatapon:masterfrom
kastdeur wants to merge 1 commit intoeonpatapon:masterfrom
Conversation
Contributor
Author
|
The code is a simple implementation of the code mentioned in #97 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
In issue #97, two options for getting cover art are mentioned.
This PR introduces the capability to prefetch cover art from the original file when it's present (both the file and the cover art therein).
It uses the code already implemented to fetch cover art from local files.
To this end, this code is slightly tweaked.
There are still a few things todo:
I made this a draft PR, no idea whether that's appropriate..