Skip to content

Try to read cover art from file in music_dir#131

Draft
kastdeur wants to merge 1 commit intoeonpatapon:masterfrom
kastdeur:remote-art2
Draft

Try to read cover art from file in music_dir#131
kastdeur wants to merge 1 commit intoeonpatapon:masterfrom
kastdeur:remote-art2

Conversation

@kastdeur
Copy link
Copy Markdown
Contributor

Hey there,

In issue #97, two options for getting cover art are mentioned.
This PR introduces the capability to prefetch cover art from the original file when it's present (both the file and the cover art therein).

It uses the code already implemented to fetch cover art from local files.
To this end, this code is slightly tweaked.

There are still a few things todo:

  • import statements: for some reason I can't get them outside the class.
  • introduce settings for a download limit, and to enable the downloading of remote file
  • code cleanup

I made this a draft PR, no idea whether that's appropriate..

@kastdeur
Copy link
Copy Markdown
Contributor Author

The code is a simple implementation of the code mentioned in #97 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant