Skip to content

Maven publishing fixes#500

Merged
AntonKanug merged 1 commit intoenvoyproxy:mainfrom
ovadiagal:govadia/fix-publishing
Mar 17, 2026
Merged

Maven publishing fixes#500
AntonKanug merged 1 commit intoenvoyproxy:mainfrom
ovadiagal:govadia/fix-publishing

Conversation

@ovadiagal
Copy link
Contributor

@ovadiagal ovadiagal commented Mar 16, 2026

Summary

v1.0.51 was released via CircleCI but never appeared on Maven Central. The OSSRH URL
migration in #484 switched to the Central Portal's compatibility API, which has stricter
artifact validation than the old OSSRH. The following 2 issues prevented publishing:

  1. test module produced an empty JAR The test module has no source code, so it produced an empty JAR that Central Portal rejects. Changed to <packaging>pom</packaging>, which avoids generating a JAR altogether

  2. Child POMs missing <name> element Central Portal now requires a <name> in
    every POM. Added it to api, cache, server, and test.

Verified by publishing a test artifact to Maven Central under a personal namespace: https://repo1.maven.org/maven2/io/github/ovadiagal/java-control-plane/0.0.1-test/

Changes

  • api/pom.xml, cache/pom.xml, server/pom.xml: add <name>
  • test/pom.xml: add <name>, set <packaging>pom</packaging>, remove
    <skipNexusStagingDeployMojo>

The new Central Portal has stricter artifact validation than the old
OSSRH. This fixes the deploy step that runs when release:prepare pushes
the release commit back to main:

- Add <name> to child POMs (now required by Central Portal)
- Change test module to pom packaging so it no longer produces an empty
  JAR that fails Central validation
- Remove skipNexusStagingDeployMojo from test module (was preventing
  deploy-at-end from triggering since test is the last reactor module)

Signed-off-by: Gal Ovadia <ggalovadia@gmail.com>
@ovadiagal ovadiagal force-pushed the govadia/fix-publishing branch from d63570c to a88caf9 Compare March 16, 2026 23:32
@ovadiagal ovadiagal changed the title Add release:perform to CI Publishing fixes Mar 16, 2026

<artifactId>test</artifactId>
<name>test</name>
<packaging>pom</packaging>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indicates that the module produces no JAR, just the POM file itself

The new API is more strict about uploading an empty jar during CI which is why things were failing after switching to the new url

@ovadiagal ovadiagal marked this pull request as ready for review March 16, 2026 23:44
@ovadiagal ovadiagal changed the title Publishing fixes Maven publishing fixes Mar 16, 2026
@AntonKanug AntonKanug merged commit c736a37 into envoyproxy:main Mar 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants