Merged
Conversation
The new Central Portal has stricter artifact validation than the old OSSRH. This fixes the deploy step that runs when release:prepare pushes the release commit back to main: - Add <name> to child POMs (now required by Central Portal) - Change test module to pom packaging so it no longer produces an empty JAR that fails Central validation - Remove skipNexusStagingDeployMojo from test module (was preventing deploy-at-end from triggering since test is the last reactor module) Signed-off-by: Gal Ovadia <ggalovadia@gmail.com>
d63570c to
a88caf9
Compare
ovadiagal
commented
Mar 16, 2026
|
|
||
| <artifactId>test</artifactId> | ||
| <name>test</name> | ||
| <packaging>pom</packaging> |
Contributor
Author
There was a problem hiding this comment.
This indicates that the module produces no JAR, just the POM file itself
The new API is more strict about uploading an empty jar during CI which is why things were failing after switching to the new url
AntonKanug
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.0.51 was released via CircleCI but never appeared on Maven Central. The OSSRH URL
migration in #484 switched to the Central Portal's compatibility API, which has stricter
artifact validation than the old OSSRH. The following 2 issues prevented publishing:
test module produced an empty JAR The test module has no source code, so it produced an empty JAR that Central Portal rejects. Changed to
<packaging>pom</packaging>, which avoids generating a JAR altogetherChild POMs missing
<name>element Central Portal now requires a<name>inevery POM. Added it to
api,cache,server, andtest.Verified by publishing a test artifact to Maven Central under a personal namespace: https://repo1.maven.org/maven2/io/github/ovadiagal/java-control-plane/0.0.1-test/
Changes
api/pom.xml,cache/pom.xml,server/pom.xml: add<name>test/pom.xml: add<name>, set<packaging>pom</packaging>, remove<skipNexusStagingDeployMojo>